FreeCADView Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000495 | FreeCAD | Bug | public | 2011-11-27 05:56 | 2019-01-16 14:49 |
| Reporter | normandc | Assigned To | |||
| Priority | normal | Severity | feature | Reproducibility | always |
| Status | confirmed | Resolution | open | ||
| Target Version | 0.19 | ||||
| Summary | 0000495: Inconsistent translations for workbench names | ||||
| Description | Currently in latest FreeCAD source, translation for workbench names is inconsistent: - Some workbenches toolbar names are translated (in View --> Toolbars menu) - Some workbench specific menu names are translated, some aren't. For example, when the workbench selector is set to a specific workbench, the workbench menu name is not translated. The Raytracing menu name is in English (but its contents are translated). But if in complete workbench mode, then most of the workbench menus are translated. - In the workbench selector, the workbench names are not translated. This should require some consideration. I realize that translating the workbench names is a delicate matter as it could complicate communication on the forums with users of other languages. But I believe that a wholly translated interface is preferable, as some English names don't have signification to users of other languages. (For example: the distinction between Draft and Drawing can be lost on French users) | ||||
| Additional Information | I'll try to post screenshots shortly. | ||||
| Tags | locale, translation | ||||
| FreeCAD Information | |||||
|
|
We have different levels of translations. Thats IMO not a bug. Besides there is a string not showing up on crowdin, that would be a bug! Otherwise its a encouragement for the translaters and I will close this "bug" ;) |
|
|
Please explain what you mean by different levels of translation. Right now, I have workbench menu names showing either in French or in English depending on if I've set the complete workbench, or if the workbench selector is set to a specific workbench. Then the workbench selector itself is not translated. How is that no a bug? And why isn't a single string used for the 3 use cases? |
|
|
I think workbench names are specified in their InitGui file, which is why they are not taken into account by the translation system. Since workbenches are activated/deactivated by name internally, changing this will require serious changes in the code. Sincerely I'm not sure it's worth the work... Their contents (toolbars, menu entries, etc) on the other hand, is taken into account by translation mechanisms and should be 100% translated. If something is missing (provided all crowdin strings are translated of course), indeed it is a bug (probably some string internally which isn't using a translation function). I suggest you make a list here with what you see that isn't translated, we'll need to go one by one... But I'm not sure it's a showstopper for 0.12... There will probably be more than a couple, and at this rate that release will never be out ;) My opinion is more to see translations as a work in progress, and refine progressively... |
|
|
What I want to make sure of is to get a sense of the direction we go. If we decide that workbench names should not (or cannot) be translated, then I will have to revert all the translations where I have translated them. And that includes the Wiki documentation... So that to prevent inconsistencies in v0.12... |
|
2011-11-29 02:06
|
|
|
2011-11-29 02:07
|
|
|
2011-11-29 02:07
|
|
|
|
I finally made screen captures. I used the Draft module as an example. First one shows the Complete workbench with all the workbench menus translated. Draft menu here is called "Planche à dessin". Second one shows the Draft workbench interface. Both the Draft menu and the workbench selector show "Draft" instead of "Planche à dessin". This is an inconsistency in my opinion. The third one shows that the Draft toolbar name is indeed translated. At this point I didn't know what to do anymore so I named it "Outils Draft" for the time being. I'd rather have the name "Planche à dessin" put everywhere but I can understand if this can't be done in v0.12. But I would like to know if it'll be possible later though. As I said otherwise I'll have to change the wiki French translation accordingly. So, should this be considered a bug? feature request? P.S. Yorik, since it's your module you may also not like the chosen name? It was first named that way by mrchep and I thought it fitting, and easy to visualize its purpose by French users. |
|
|
Normally in latest revision all appearences of "Draft" in menus can be translated. Check if the crowdin stuff is OK, then I'll add them again to the sources. For the other workbenches we need to see which ones don't translate correctly. For me the name is fine, being Draft or Planche à dessin... But one thing I'll not be able to change is how the workbench names appear in the workbenches dropdown box. If this will be possible in the future or not is more up to Jürgen or Werner, and it would probably require some heavy changes to the source code... |
|
|
I will move the Workbench selector to a menu structure for the most common workbenches. So we have a translation and more information... |
|
|
There are still inconsistencies in translations ("Draft" is not translated equally on crowdin (sometimes "Planche à dessin", sometimes "Ébauche" , sometimes "Draft"), same problem in other languages too... But outside that problem all python-generated menus appear now to be correctly translated. The only thing missing is to translate the WB selector itself. I believe this is possible (in Gui/Actions.cpp, class WorkbenchComboBox), it looks like the individual actions that compose the selector are always get/set by their objectName, so there would be no problem in setting their displayed text to something else, but I'm not too sure where to get the translations... |
|
|
@yorik is this still the case? |
|
|
@normandc can you recheck this please when you have a moment? |
|
|
Yes it is still the case, workbench names are not trasnlated in the workbench selector. I think there was a discussion about that on the forum in the past... |
|
|
@yorik I searched the forum but no joy. Do you mind trying to find this thread and associating it to this ticket? |
|
|
Cannot find it back... I guess it was spread over several discussions... |
|
|
@yorik do you think this should make it in to 0.17? |
|
|
I don't know how to handle this, so I couldn't say... |
|
|
Opened new forum thread: https://forum.freecadweb.org/viewtopic.php?f=8&t=22936&p=178016 |
|
|
Unassigning Jriegel |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-11-27 05:56 | normandc | New Issue | |
| 2011-11-27 18:00 |
|
Note Added: 0001357 | |
| 2011-11-27 18:16 | normandc | Note Added: 0001362 | |
| 2011-11-27 19:12 | yorik | Note Added: 0001364 | |
| 2011-11-27 19:43 | normandc | Note Added: 0001365 | |
| 2011-11-29 02:06 | normandc | File Added: FC_complete.png | |
| 2011-11-29 02:07 | normandc | File Added: FC_draft_workbench.png | |
| 2011-11-29 02:07 | normandc | File Added: FC_Draft_toolbar.png | |
| 2011-11-29 02:21 | normandc | Note Added: 0001373 | |
| 2011-11-29 12:08 | yorik | Note Added: 0001375 | |
| 2012-12-20 22:15 |
|
Note Added: 0002728 | |
| 2012-12-20 22:15 |
|
Assigned To | => Jriegel |
| 2012-12-20 22:15 |
|
Status | new => assigned |
| 2012-12-20 22:15 |
|
Target Version | => 0.14 |
| 2014-06-25 12:10 | wmayer | Target Version | 0.14 => 0.15 |
| 2015-01-25 15:48 | yorik | Target Version | 0.15 => |
| 2015-01-25 16:09 | yorik | Note Added: 0005734 | |
| 2017-02-02 21:21 | Kunda1 | Tag Attached: locale | |
| 2017-02-02 21:21 | Kunda1 | Tag Attached: translation | |
| 2017-05-30 23:48 | Kunda1 | Note Added: 0009205 | |
| 2017-05-30 23:49 | Kunda1 | Target Version | => 0.17 |
| 2017-05-30 23:49 | Kunda1 | Note Added: 0009206 | |
| 2017-05-31 16:38 | yorik | Note Added: 0009225 | |
| 2017-05-31 17:34 | Kunda1 | Tag Attached: #post-to-forum | |
| 2017-06-10 04:53 | Kunda1 | Note Added: 0009327 | |
| 2017-06-13 17:24 | yorik | Note Added: 0009356 | |
| 2017-06-13 21:49 | Kunda1 | Note Added: 0009359 | |
| 2017-06-14 01:21 | yorik | Note Added: 0009360 | |
| 2017-06-14 12:44 | Kunda1 | Note Added: 0009366 | |
| 2017-06-14 12:44 | Kunda1 | Tag Detached: #post-to-forum | |
| 2017-12-02 14:47 | wmayer | Target Version | 0.17 => 0.18 |
| 2018-06-13 13:25 | Kunda1 | Assigned To | Jriegel => |
| 2018-06-13 13:25 | Kunda1 | Status | assigned => confirmed |
| 2018-06-13 13:25 | Kunda1 | Note Added: 0011420 | |
| 2019-01-16 14:49 | wmayer | Target Version | 0.18 => 0.19 |
