View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0000492||FreeCAD||Feature||public||2011-11-23 13:33||2017-04-28 12:33|
|Priority||normal||Severity||minor||Reproducibility||have not tried|
|Target Version||0.13||Fixed in Version||0.13|
|Summary||0000492: Sketcher: Create from existing 2d elements|
|Tags||No tags attached.|
I could work on this one.
||Me too... I'll assign this to myself, but Dan feel free to work on it... (I attach your macro here...)|
||IMO we should avoid to make the Sketcher dependent on the Draft module. My idea actually is to load the DXF file with the Draft module as usual and then from the created document transfer all the 2d geometry types to a sketcher object. This approach is also more flexible because you can convert a draft you did to a sketcher.|
Yes I totally agree with that, it is indeed what I had in mind too, a simple tool that converts between sketch and draft.
And if there is also a DXF importer that makes a sketch directly, it should belong to the sketcher module and not depend on the draft module...
I think in future a dxf to sketch converter can also create some constraints
(as an option) Thats not possible in the Draft module...
||The Draft module now has a Draft <-> Sketch tool. I'll leave this open in case Dan or someone else (me maybe) wants to work on a Sketcher DXF importer|
||It would be nice to open a transaction so that it is undo/redo-able.|
||Oops that's true... Thanks for looking! I just fixed that.|
IMHO I see no need to have an extra DXF importer for the Sketcher module. The process as it is now to load a DXF file in the Draft module and use this awesome function to convert is absolutely sufficient. Why re-inventing the wheel (with a second DXF importer)?
Maybe the only thing I would do then is to implement a function in Draft that loads the DXF and convert it immediately to a Sketcher. In the Complete wb this command then can be added to the Sketcher menu, too.
Good idea too! About direct DXF import in the sketcher I kind of agree, but why not, if someone wishes to do it... Maybe I'll close this report when this tool is good, though, and that would be for another one, if any.
Note to self - Things I'll still implement here:
- merge all in one result if several objects of same type are selected
- do not produce anything if it's a spline
- add basic constraints when applicable (wires, rectangles, circles)
- add "Auto-sketch" option in DXF import
The 4 features from the post above are now implemented in r5238. I just couldn't implement auto-radius yet because there is no python binding for it yet in Sketcher ConstraintsPy. When I have a minute more I'll look into fixing it.
To import DXF files directly to sketches, now, it's just a matter of selecting "Create Sketches" in Preferences->Draft->DXF->Import type. If any of the options "make blocks" or "join geometry" is marked, ALL the imported file will go in ONE sketch (might become pretty heavy)
There are now autoconstraints on wires and rectangles too. I separated the sketch making function from the GUI tool, so that it also by used from python with Draft.makeSketch(list_of_objects,autoconstraints=False)
Now there are certainly some remaining bugs around...
||Okay I think we can consider this done now... Any problem just reopen!|
|2011-11-23 13:33||wmayer||New Issue|
|2011-11-23 19:47||danielfalck||Note Added: 0001342|
|2011-11-24 00:56||yorik||Note Added: 0001344|
|2011-11-24 00:57||yorik||File Added: DXF2Sketch.py|
|2011-11-24 00:57||yorik||Status||new => assigned|
|2011-11-24 00:57||yorik||Assigned To||=> yorik|
|2011-11-26 10:18||wmayer||Note Added: 0001353|
|2011-11-26 12:50||yorik||Note Added: 0001354|
||Note Added: 0001376|
|2011-12-07 13:54||yorik||Note Added: 0001413|
|2011-12-07 16:16||wmayer||Note Added: 0001415|
|2011-12-07 17:24||yorik||Note Added: 0001416|
|2011-12-08 07:58||wmayer||Note Added: 0001421|
|2011-12-08 08:01||wmayer||Note Edited: 0001421|
|2011-12-08 09:39||yorik||Note Added: 0001423|
|2011-12-08 13:32||yorik||Note Added: 0001424|
|2012-01-10 13:24||yorik||Note Added: 0001552|
|2012-01-10 13:24||yorik||Status||assigned => closed|
|2012-01-10 13:24||yorik||Resolution||open => fixed|
|2012-01-10 13:24||yorik||Fixed in Version||=> 0.13|
|2017-04-28 12:33||Kunda1||Description Updated|