FreeCAD|
|
Translation-PD.png (68,295 bytes) |
|
|
Yikes, src/Mod/PartDesign/Gui/Workbench.cpp is super hard to read https://github.com/FreeCAD/FreeCAD/blob/c7c420ca1d2f7779d2cd75f3fd98162c62f235b8/src/Mod/PartDesign/Gui/Workbench.cpp#L51-L62 @openBrain do you mind with an assist? :) |
|
|
@Kunda1 : saw your ping. Beyond I'm not sure I can help here, I've entered a tough busy period that will basically keep me away from contributing for some weeks (hopefully not more). Sorry for that. |
|
|
@chennes would you have a moment to help me with this? |
|
|
Sure - you really need to be looking at lines 491-522, that's where the untranslated strings are. I don't know why they aren't translated, maybe that comment above was intended as a sort of "note to self"? Anyway, I think I can make a PR here if you want. |
|
|
I see - they aren't commands, they are submenus. Those have to get handled differently. PR 4570 |
|
|
Oh, it looks like there is a problem in the regex for directories that are getting stripped "src/Mod/Part" also matches "src/Mod/PartDesign" so updatets isn't doing that one. |
|
|
Apologies for not including this tracker ticket # in the commit -- I believe that this issue will be fixed by FreeCAD master 6789ddaa, but I wouldn't close the ticket until it's confirmed that those PartDesign TS files are being processed correctly now. |
|
|
Setting to Confirmed pending confirmation that this did indeed fix the issue. |
|
|
OS: Manjaro Linux (KDE/plasma) Word size of FreeCAD: 64-bit Version: 0.20.25429 (Git) AppImage Build type: Release Branch: master Hash: acce57a25d82b0408fa07b9452ed31c8a06c7a1b Python version: 3.9.6 Qt version: 5.12.9 Coin version: 4.0.0 OCC version: 7.5.2 Locale: English/United States (en_US) "Create [additive|subtractive] feature" is fixed. But some translations remain broken (bottom of screenshot of the first notation of this ticket) Sprocket... Involute gear Shaft design wizard A while back I tried to address this in PR FreeCAD Pull Request 4850 Specifically commit c:FreeCAD:c46036a1b8a0c57c8b160afa8bdf56e75a33aa04: (link to commit) But still unsuccessful |
|
|
It doesn't look like any of the Python code in PartDesign is being translated: at least, it's not listed in the PyCommands variable in updatets.py. |
|
|
OK, can you test this PR and see if it grabs the missing translation strings in PartDesign? https://github.com/FreeCAD/FreeCAD/pull/4961 |
|
|
That PR has now been merged, and I believe fully addresses the missing translations in PartDesign's Python code. |
- Anonymous
