View Issue Details

IDProjectCategoryView StatusLast Update
0004001SketcherBugpublic2020-10-25 15:13
Reporteruwestoehr Assigned Touwestoehr  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version0.18 
Summary0004001: Sketcher trimming issue with arcs
DescriptionWhen trimming 2 intersecting arcs the trimming fails when the endpoint of one arc is coincident with the second arc. Moreover the trimming cannot be undone.

To reproduce open the attached file and trim the upper ends of the arcs so that only one arc segment would be left. The interesting thing is that the result cannot be foreseen and that in all cases the trimming cannot be undone.
Here is one try:

but sometimes I end up with 2 arc segments not intersecting each other but being connected in one point.
Additional InformationForum thread: https://forum.freecadweb.org/viewtopic.php?p=311853

Confirmed by @abdullah

OS: Windows 7
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.16117 (Git)
Build type: Release
Branch: releases/FreeCAD-0-18
Hash: dbb4cc6415bac848a294f03b80f65e888d531742
Python version: 3.6.6
Qt version: 5.6.2
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: German/Germany (de_DE)
TagsOCC 7.4, sketcher, undo, upstream
FreeCAD Information

Activities

uwestoehr

2019-06-05 23:02

manager  

uwestoehr

2019-06-05 23:03

manager  

Trimming-Bug1.gif (519,486 bytes)   
Trimming-Bug1.gif (519,486 bytes)   

uwestoehr

2019-06-06 22:53

manager   ~0013154

As stated in the forum thread the missing undo is a FreeCAD bug independent of OCCT and should be fixed in any case.

uwestoehr

2019-06-25 23:24

manager   ~0013312

@abdullah, should I open a separate bug for the undo issue?

Kunda1

2019-08-23 02:50

administrator   ~0013460

@uwestoehr did you ever get a response from abdullah on this ?
When you do please link said ticket to this one. Thanks!

abdullah

2020-05-26 15:30

manager   ~0014427

PR for the undo part:
https://github.com/FreeCAD/FreeCAD/pull/3514

The special handling I leave it for when OCCT fixes their routine, as the work-around code is already convoluted enough.

uwestoehr

2020-05-31 01:42

manager   ~0014449

Many thanks. I can confirm that undo works now fine.

uwestoehr

2020-10-24 22:09

manager   ~0014946

With current FC 0.19 and OCC 7.4.0 I can no longer reproduce the bug.

uwestoehr

2020-10-24 22:10

manager   ~0014947

Obviously this OCC issue has been fixed in OCC 7.4

Kunda1

2020-10-25 15:12

administrator   ~0014951

Also FreeCAD master 6f3160db

Kunda1

2020-10-25 15:13

administrator   ~0014952

Closing ticket

Related Changesets

FreeCAD: master 6f3160db

2020-05-26 15:18:33

abdullah


Committer: abdullahtahiriyo Details Diff
Sketcher: Enable undo when trimming

===================================

Reported here:
https://forum.freecadweb.org/viewtopic.php?p=311853#p312647
Affected Issues
0004001
mod - src/Mod/Sketcher/App/SketchObject.cpp Diff File

Issue History

Date Modified Username Field Change
2019-06-05 23:02 uwestoehr New Issue
2019-06-05 23:02 uwestoehr Tag Attached: sketcher
2019-06-05 23:02 uwestoehr File Added: Sketch-cut-problem.FCStd
2019-06-05 23:03 uwestoehr File Added: Trimming-Bug1.gif
2019-06-05 23:04 uwestoehr Description Updated
2019-06-06 22:53 uwestoehr Note Added: 0013154
2019-06-06 22:54 uwestoehr Tag Attached: undo
2019-06-17 10:06 uwestoehr Additional Information Updated
2019-06-25 23:24 uwestoehr Note Added: 0013312
2019-08-23 02:50 Kunda1 Note Added: 0013460
2019-08-23 02:51 Kunda1 Target Version => 0.19
2020-05-26 15:30 abdullah Note Added: 0014427
2020-05-31 01:42 uwestoehr Note Added: 0014449
2020-10-24 22:09 uwestoehr Note Added: 0014946
2020-10-24 22:10 uwestoehr Assigned To => uwestoehr
2020-10-24 22:10 uwestoehr Status new => resolved
2020-10-24 22:10 uwestoehr Resolution open => fixed
2020-10-24 22:10 uwestoehr Note Added: 0014947
2020-10-25 15:11 Kunda1 Tag Attached: upstream
2020-10-25 15:11 Kunda1 Tag Attached: OCC 7.4
2020-10-25 15:12 Kunda1 Note Added: 0014951
2020-10-25 15:12 Kunda1 Changeset attached => FreeCAD master 6f3160db
2020-10-25 15:13 Kunda1 Status resolved => closed
2020-10-25 15:13 Kunda1 Note Added: 0014952