0003721: Some of the Part menu items are not translatable

ID	Project	Category	View Status	Date Submitted	Last Update

0003721	Part	Feature	public	2018-12-09 18:30	2018-12-10 13:03

Reporter	normandc	Assigned To	yorik
Priority	normal	Severity	minor	Reproducibility	N/A
Status	closed	Resolution	fixed
Product Version	0.18
Target Version	0.18	Fixed in Version	0.18

Summary	0003721: Some of the Part menu items are not translatable
Description	In the Part menu, the Join/Split/Compound submenu and their content, as well as the Attachment item are not found in the translation strings on Crowdin and therefore cannot be translated.
Tags	No tags attached.

FreeCAD Information

normandc 2018-12-09 18:30 manager	FC018_Part_Compound_menu_01.png (67,815 bytes) FC018_Part_Compound_menu_01.png (67,815 bytes)

normandc 2018-12-09 18:41 manager ~0012248	Edit: issue exists also with Join/Split and Attachment.

Kunda1 2018-12-10 11:43 administrator ~0012250	Where are they in the source ? Is it: https://github.com/FreeCAD/FreeCAD/blob/master/src/Mod/Part/CompoundTools/_CommandCompoundFilter.py#L58 `return {'Pixmap': ":/icons/Part_CompoundFilter.svg", 'MenuText': QtCore.QT_TRANSLATE_NOOP("Part_CompoundFilter", "Compound Filter"), 'Accel': "", 'ToolTip': QtCore.QT_TRANSLATE_NOOP("Part_CompoundFilter", "Compound Filter: remove some childs from a compound")}`

Kunda1 2018-12-10 11:56 administrator ~0012251	@yorik some translations have `QtCore.QT_TRANSLATE_NOOP()` and some have `QT_TRANSLATE_NOOP()` What is the difference ?

yorik 2018-12-10 13:02 administrator ~0012253 Last edited: 2018-12-10 13:03	Fixed with https://github.com/FreeCAD/FreeCAD/commit/f56198dd3387be2be45aaf290ab5eef36bc89d13 The crowdin files have been updated too. @Kunda1 no difference. Only the QtCore module was imported differentyl in both cases...

Date Modified	Username	Field	Change
2018-12-09 18:30	normandc	New Issue
2018-12-09 18:30	normandc	File Added: FC018_Part_Compound_menu_01.png
2018-12-09 18:41	normandc	Description Updated
2018-12-09 18:41	normandc	Note Added: 0012248
2018-12-09 18:42	normandc	Summary	Part --> Compound and Compound Filter are not translatable => Some of the Part menu items are not translatable
2018-12-10 11:43	Kunda1	Note Added: 0012250
2018-12-10 11:56	Kunda1	Note Added: 0012251
2018-12-10 13:02	yorik	Note Added: 0012253
2018-12-10 13:03	yorik	Note Edited: 0012253
2018-12-10 13:03	yorik	Assigned To	=> yorik
2018-12-10 13:03	yorik	Status	new => closed
2018-12-10 13:03	yorik	Resolution	open => fixed
2018-12-10 13:03	yorik	Fixed in Version	=> 0.18