View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0003205 | Project Tools & Websites | General | public | 2017-10-01 12:24 | 2022-01-23 00:13 |
Reporter | Kunda1 | Assigned To | |||
Priority | low | Severity | feature | Reproducibility | N/A |
Status | closed | Resolution | fixed | ||
Target Version | 0.20 | Fixed in Version | 0.20 | ||
Summary | 0003205: TravisCI to check spelling of submitted Pull Requests to FC repo | ||||
Description | Based on this tutorial we could use codespell to run spelling checks on submitted PRs to travis. This test won't stop builds from building but should notify the user via the PR notes which typos were found. Currently testing is done manually via:
Somethings to resolve technically:
| ||||
Additional Information | Upstream codespell ticket: https://github.com/lucasdemarchi/codespell/issues/139 | ||||
Tags | TravisCI, unit-test | ||||
FreeCAD Information | |||||
|
According to one of the upstream codespell devs:
|
|
submitted test PR in FreeCAD Pull Request 1039 |
|
Problem, need to abandon the api token methodology and use webhooks. See https://github.com/FreeCAD/FreeCAD/pull/1039#issuecomment-336982942 |
|
This is probably obsolete now: we could consider using GitHub actions. |
|
Thanks to Floriansimmer we have a codespell github action https://github.com/FreeCAD/FreeCAD/commit/c7cf9b25dfc6ec4fbbba8db7adfd7eb54be105fa |
Date Modified | Username | Field | Change |
---|---|---|---|
2017-10-01 12:24 | Kunda1 | New Issue | |
2017-10-01 12:24 | Kunda1 | Tag Attached: unit-test | |
2017-10-01 12:24 | Kunda1 | Tag Attached: TravisCI | |
2017-10-01 14:25 | Kunda1 | Additional Information Updated | |
2017-10-01 14:27 | Kunda1 | Note Added: 0010227 | |
2017-10-01 20:11 | Kunda1 | Relationship added | related to 0003206 |
2017-10-01 20:39 | Kunda1 | Status | new => assigned |
2017-10-01 20:39 | Kunda1 | Assigned To | => Kunda1 |
2017-10-13 09:45 | Kunda1 | Description Updated | |
2017-10-14 16:08 | Kunda1 | Note Added: 0010296 | |
2017-10-16 18:54 | Kunda1 | Note Added: 0010303 | |
2017-11-12 17:26 | Kunda1 | Relationship added | child of 0003259 |
2021-02-06 06:36 | abdullah | Target Version | => 0.20 |
2021-12-17 03:53 | chennes | Note Added: 0016108 | |
2022-01-23 00:13 | Kunda1 | Assigned To | Kunda1 => |
2022-01-23 00:13 | Kunda1 | Status | assigned => closed |
2022-01-23 00:13 | Kunda1 | Resolution | open => fixed |
2022-01-23 00:13 | Kunda1 | Fixed in Version | => 0.20 |
2022-01-23 00:13 | Kunda1 | Note Added: 0016250 |