View Issue Details

IDProjectCategoryView StatusLast Update
0002720FreeCADBugpublic2016-10-04 21:00
ReporterDeepSOIC Assigned ToDeepSOIC  
Status closedResolutionfixed 
Product Version0.17 
Target Version0.17 
Summary0002720: Scripts that use Part Extrude are broken
DescriptionRecent changes to Part Extrude to use FaceMaker caused breakage of OpenSCAD importer. The culprit is that Extrude now treats Solid property as strict: if Solid is true, Extrude tries to use facemaker regardless of what is being extruded. Facemaker then fails, because it expects wires, not e.g. faces or shells.
Steps To Reproduce
Additional InformationOS: Ubuntu 14.04.5 LTS
Word size of OS: 32-bit
Word size of FreeCAD: 32-bit
Version: 0.17.8576 (Git)
Build type: None
Branch: master
Hash: 65a935f9ae164aa6857b77afcb2be6792435914c
Python version: 2.7.6
Qt version: 4.8.6
Coin version: 4.0.0a
OCC version: 6.8.0.oce-0.17
TagsNo tags attached.
FreeCAD Information



2016-10-04 15:36

developer   ~0007341

Todo: also check usages of Revolve...

Related Changesets

FreeCAD: master d21f339a

2016-10-04 20:51:58


Details Diff
Part: Extrude, Revolve: fix 0002720 - relax action of Solid=true

When facemakers were introduced, Solid property of Revolve and Extrude
was made strict: it calls facemaker if Solid==true, and facemaker would
fail if shape being extruded/revolved is a face.

This is fixed by testing there are no faces in source shape prior to
calling facemaker.
Affected Issues
mod - src/Mod/Part/App/FeatureExtrusion.cpp Diff File
mod - src/Mod/Part/App/FeatureRevolution.cpp Diff File

Issue History

Date Modified Username Field Change
2016-10-04 15:34 DeepSOIC New Issue
2016-10-04 15:34 DeepSOIC Status new => assigned
2016-10-04 15:34 DeepSOIC Assigned To => DeepSOIC
2016-10-04 15:36 DeepSOIC Note Added: 0007341
2016-10-04 21:00 DeepSOIC Changeset attached => FreeCAD Master master d21f339a
2016-10-04 21:00 DeepSOIC Status assigned => closed
2016-10-04 21:00 DeepSOIC Resolution open => fixed