View Issue Details

IDProjectCategoryView StatusLast Update
0002477ExpressionsBugpublic2020-02-27 18:11
ReporterHastux Assigned Torealthunder  
PrioritynormalSeverityminorReproducibilityalways
Status assignedResolutionopen 
PlatformLinuxOSUbuntu 
Summary0002477: Copy of sub objects with expression pointing to a spreadsheet shall not create a new spreadsheet
DescriptionVersion: 0.16
Revision: 6621 (Git)
System: Ubuntu with ppa/daily

When copying an object with expression linked to a spreadsheet (containing alias as variables), the dialog box ask to copy or not linked objects. When we answer yes, it copies the objects, and also create a new spreadsheet. The original object is pointing to the new spreadsheet and the new one to the original spreadsheet. It is not clearly a bug, because all is copied as asked, but it is really annoying to change all expression to point to a single spreadsheet.

Proposition: ask to not copy or not the spreadsheet when a link between an expression and a spreadsheet is detected

PS: A great thanks to all of you, working in the shadow, this software is better and better
Steps To Reproduce-Create a spreadsheet ('var') with an alias ('x') pointing to a value
-Create an object an set and expression pointing to this alias (length = var.x)
-Create an array of this object
-Copy the array and answer yes to copy dependencies
Tagsexpressions, spreadsheet
FreeCAD Information

Relationships

related to 0003271 closedrealthunder Relative file references give 'Document not found' unless that file is opened first 
related to 0003272 new Failed to parse expression occurs when referencing an alias in an external spreadsheet document 

Activities

eivindkvedalen

2017-07-26 09:52

developer   ~0009824

I'm not able to recreate this problem in 0.16r6706. I get the objects duplicated, but no dependencies are created to the new spreadsheet, so this can easily be removed afterwards.

Kunda1

2017-07-26 10:59

administrator   ~0009826

@eivindkvedalen FYI, the latest stable 0.16 is revision 6712

Kunda1

2017-11-10 16:57

administrator   ~0010408

@eivindkvedalen can this issue be closed ?

eivindkvedalen

2017-11-11 09:12

developer   ~0010409

No, I see room for improvement on this one, so we shouldn't close it.

Sergei Kulik

2018-12-04 00:15

reporter   ~0012236

I confirm this issue as described is present on 0.18.15316_x64_dev_win. Let me know if you need a detailed scenario or project.

realthunder

2020-02-27 08:59

developer   ~0014189

After this commit in upstream, a dialog will popup when the user copies any object with dependency. User has full control on which dependencies to copy.

The commit is huge as it is done during the big merge. The object selection is done with DlgObjectSelection. Just search the source tree for usage of this class.

In addition, with this commit (inside a pending PR), the expression can auto change its reference to/from internal/external reference depending on whether the referenced object is copied to the external document or not.

For example, assuming there is a spreadsheet referencing a sketch in the same document (DocA) as 'Sketch.Constraints.myConstraint'. And now if the spreadsheet is copied into an external document, but the referenced sketch object is not copied together. The expression will be auto changed to 'DocA#Sketch.Constraints.myConstraint'.

Issue History

Date Modified Username Field Change
2016-03-15 17:40 Hastux New Issue
2017-01-06 16:30 eivindkvedalen Assigned To => eivindkvedalen
2017-01-06 16:30 eivindkvedalen Status new => assigned
2017-01-19 14:25 Kunda1 Tag Attached: spreadsheet
2017-05-07 15:01 Kunda1 Tag Attached: expressions
2017-07-26 09:52 eivindkvedalen Note Added: 0009824
2017-07-26 10:59 Kunda1 Note Added: 0009826
2017-11-10 16:57 Kunda1 Note Added: 0010408
2017-11-11 09:12 eivindkvedalen Note Added: 0010409
2017-12-09 12:55 Kunda1 Relationship added related to 0003271
2017-12-09 13:03 Kunda1 Relationship added related to 0003272
2017-12-13 15:27 Kunda1 Project FreeCAD => Expressions
2018-12-04 00:15 Sergei Kulik Note Added: 0012236
2020-02-27 08:59 realthunder Note Added: 0014189
2020-02-27 18:11 Kunda1 Assigned To eivindkvedalen => realthunder