View Issue Details

IDProjectCategoryView StatusLast Update
0001682DrawingBugpublic2019-07-29 15:16
Reportertinman Assigned Towmayer  
Status closedResolutionfixed 
OSWindowsOS Version7 
Product Version0.14 
Summary0001682: Crash after updating editable texts in drawing
DescriptionAfter editing the texts in the "Editable Texts" data property of a drawing page FreeCAD crashes.
Steps To Reproduce1) Start FreeCAD
2) Switch to Part workbench and place a cube
3) Switch to Drawing workbench and create new drawing based on A3 template "C:/Program Files/FreeCAD 0.14/data/Mod/Drawing/Templates/A3_Landscape.svg"
4) Select the new drawing page in the combo view
5) Switch to Data page in the properties view
6) Click on the "..." button to bring up the editor window for "Editable Texts"
7) Replace "AUTHOR NAME" with "TESTTEST" and click on "OK"
8) Press "Enter" to confirm change from "Editable Text" single line property editor
TagsNo tags attached.



2014-08-12 23:30

administrator   ~0004940

Happens inside FeaturePage::execute() and there in the second "while" loop.


2014-08-13 03:40

administrator   ~0004941

It doesn't crash for me... Any more info? It's strange, that stuff has been there for a while...


2014-08-13 06:18

administrator   ~0004942

The erroneous part is this:

string::const_iterator begin, end;
begin = outfragment.begin();
end = outfragment.end();
outfragment = boost::regex_replace(outfragment, e2, "$1>"+EditableTexts.getValues()[count]+"$3");

So, the crash is logical because the iterators "begin" and "end" become invalid when "outfragment" changes. Further down "begin" is set again but not "end".


2014-08-13 14:15

administrator   ~0004944

Argh stupid mistake :) thanks for fixing! Strange that it didn't cause a crash here

Related Changesets

FreeCAD: master 7939027c

2014-08-13 12:49:09


Details Diff
+ fixes 0001682: Crash after updating editable texts in drawing Affected Issues
mod - src/Mod/Drawing/App/FeaturePage.cpp Diff File

FreeCAD: releases 3ecaf877

2014-08-28 15:27:35


Details Diff
- fix focus issue with InputField
- on document load set camera setting of the MDI views
- do not try to use framebuffer objects when it's not supported on the system
0001690: sketch.getPoint crashes FreeCAD if the point does not exist
0001630: IGES-Export in [mm] turns to [Inches]
0001684: Sweep ignores the list of subshapes
0001667: 'Save file' disabled when viewing a drawing
0001682: Crash after updating editable texts in drawing
0001659: 3dconnexion space navigator moves view even when FreeCAD is not the active application
0001696: Quantity.getValueAs('rad') touches the Property
0001638: Not possible to draw anything
Affected Issues
0001630, 0001638, 0001659, 0001667, 0001682, 0001684, 0001690, 0001696
mod - src/App/Application.cpp Diff File
mod - src/Base/QuantityPy.xml Diff File
mod - src/Gui/Application.cpp Diff File
mod - src/Gui/Document.cpp Diff File
mod - src/Gui/GuiApplicationNativeEventAware.cpp Diff File
mod - src/Gui/InputField.cpp Diff File
mod - src/Gui/MouseSelection.cpp Diff File
mod - src/Mod/Drawing/App/FeaturePage.cpp Diff File
mod - src/Mod/Drawing/Gui/DrawingView.cpp Diff File
mod - src/Mod/Part/App/PartFeatures.cpp Diff File
mod - src/Mod/Part/App/TopoShape.cpp Diff File
mod - src/Mod/Sketcher/App/SketchObjectPyImp.cpp Diff File

Issue History

Date Modified Username Field Change
2014-08-12 22:10 tinman New Issue
2014-08-12 23:12 wmayer Status new => confirmed
2014-08-12 23:30 wmayer Note Added: 0004940
2014-08-13 03:40 yorik Note Added: 0004941
2014-08-13 06:18 wmayer Note Added: 0004942
2014-08-13 11:22 wmayer Changeset attached => FreeCAD Master master 7939027c
2014-08-13 11:22 wmayer Assigned To => wmayer
2014-08-13 11:22 wmayer Status confirmed => closed
2014-08-13 11:22 wmayer Resolution open => fixed
2014-08-13 14:15 yorik Note Added: 0004944
2019-07-29 15:16 Kunda1 Changeset attached => FreeCAD releases 3ecaf877