FreeCAD: master 47c0859c

Author Committer Branch Timestamp Parent
abdullah wmayer master 2015-09-08 20:08:47 master 185735ca
Affected Issues  0002225: Deleting link to external geometry crashes FreeCAD
Changeset Sketcher: Bug fixes: inability to create links to external geometry


First bug: Inability to create links to external geometry as described here:

Second bug: FC crashes on changing the support after having imported external geometry as described here:

and solving this ticket:

Solution to first bug:

If for some reason a sketch ends up having a list of external geometries (property) that can not be recreated (rebuilt),
they remain latent, do not show the external elements in the elements widget or in the screen and prevent adding the
elements again.

In cases where the saved file contains invalid external geometry links (which will give raise to a handled exception that would prevent external geometry creation),
this condition gets detected during restore and the invalid links are deleted before external geometry creation, so as to allow the rest of external links to be recreated.

Solution to second bug:

It is also related to invalid external links (the link was existing, but upon change on the support, it is possible that an external edge is no longer valid, reduction of edges in support).
This situation is detected upon entering into edit mode, and the invalid ones are deleted.

Note that there is still the possibility for the user to remap an invalid sketch BEFORE editing, if the remapping is successful, it may not be necessary to delete links (all depends on the
specific case).
mod - src/Mod/Sketcher/App/SketchObject.cpp Diff File
mod - src/Mod/Sketcher/App/SketchObject.h Diff File
mod - src/Mod/Sketcher/Gui/ViewProviderSketch.cpp Diff File