FreeCADFreeCAD: master 7306ed28
| Author | Committer | Branch | Timestamp | Parent |
|---|---|---|---|---|
| uwestoehr | uwestoehr | master | 2020-12-13 05:12:35 | master 305fb03c |
| Changeset | [PD] fix blind hole depth handling as reported in https://tracker.freecadweb.org/view.php?id=3818 we treat the blind hole depth not according to the conventions. The size of the drill point due to the angle is normally not taken into account but FC does this in any case. This PR adds therefore an option, that is by default off, to take the drill point size into account. Without the option, (the new default) the depth is calculated according to the conventions. The PR also removes unused widgets and restored the tab order in the .ui file. The thread parameters were never used. In case we made in future the decision to carve into holes real (modeled) threads, we need a special UI for that solution anyway so having the dead code in is not helpful at all. |
|||
| mod - src/Mod/PartDesign/App/FeatureHole.cpp | Diff File | |||
| mod - src/Mod/PartDesign/App/FeatureHole.h | Diff File | |||
| mod - src/Mod/PartDesign/Gui/TaskHoleParameters.cpp | Diff File | |||
| mod - src/Mod/PartDesign/Gui/TaskHoleParameters.h | Diff File | |||
| mod - src/Mod/PartDesign/Gui/TaskHoleParameters.ui | Diff File | |||
| mod - src/Mod/PartDesign/PartDesignTests/TestHole.py | Diff File | |||
