FreeCAD: master 11f55007

Author Committer Branch Timestamp Parent
abdullah abdullahtahiriyo master 2020-06-07 11:34:32 master 652d965d
Affected Issues  0004241: Crash when task panel stays open in FreeCAD Daily
Changeset PartDesign: closing task dialog when exiting edit mode for Primitives

=====================================================================

fixes 0004241

Problem:

PartDesignGui::ViewProvider is responsible for closing the tasks for most of PD features when exiting edit mode
(i.e. unsetEdit()).

For primitives, PartDesignGui::ViewProviderPrimitive is responsible, and neither does it or relies on its parent
VP to do it when calling unsetEdit().

Solution:

Make PartDesignGui::ViewProviderPrimitive::unsetEdit() rely on parent PartDesignGui::ViewProvider to tidy up,
including closing the task dialog.

Reference:

This is the default stack call when closing a document while a PD task using PartDesignGui::Viewprovider is active:
mod - src/Mod/PartDesign/Gui/ViewProviderPrimitive.cpp Diff File