Changesets: FreeCAD

master 0a917049

2020-06-08 04:41:29

russ4262

Details Diff
Path: Fix error when selection includes vertical faces.
Attach Issues:
mod - src/Mod/Path/PathScripts/PathSurfaceSupport.py Diff File

master bec4afa3

2020-06-08 04:38:53

Gabriel Wicke


Committer: GitHub Details Diff
Merge branch 'master' into optimizeLinearSegments_fix
Attach Issues:
mod - src/Mod/Part/App/FeatureFillet.cpp Diff File

master 905d9d65

2020-06-08 03:09:55

Gabriel Wicke

Details Diff
Path: Area fixes and robustness tweaks

- Bug fix: Fix crasher in discretize() when the edge to discretize is
not a 3d curve, and a nullptr is returned when trying to access the
underlying curve. This change essentially removes an older work-around
for QuasiUniformDeflection, which is no longer needed since we are
using UniformDeflection. This change is tested with the original test
case from https://forum.freecadweb.org/viewtopic.php?f=15&t=42628, as
well as my own crasher test case.
- WireJoiner robustness: Support passing in a tolerance into
WireJoiner::findCloseWires(), and initialize this to
AreaParameter.Tolerance. In testing, this significantly improves the
ability to join projected areas in complex 3d surface path models.
- Area::project() robustness: Pass the work plane down into the
projection area instance, so that it does not need to be derived from
shapes. This avoids crashing out on "shapes are not coplanar" from
getPlane, when lenient processing was requested via the Coplanar
parameter.
Attach Issues:
mod - src/Mod/Path/App/Area.cpp Diff File
mod - src/Mod/Path/App/Area.h Diff File

master 33d1d281

2020-06-08 02:43:31

russ4262

Details Diff
Path: Convert `SetupProperties()` to dynamic code

This method will always synchronize with operation's class properties.
Attach Issues:
mod - src/Mod/Path/PathScripts/PathSurface.py Diff File
mod - src/Mod/Path/PathScripts/PathWaterline.py Diff File

master 8679bdbd

2020-06-08 00:00:36

vocx-fc


Committer: yorik Details Diff
Draft: separate target into object and subelements in make_label

Before, the `make_label` function had a `target` parameter
that had to be a `LinkSub`, `[Part::Feature, "Edge1"]`.
However, it is easier to pass the individual components
separately using two parameters, `target_object` and `subelements`,
which can then be assembled into `[target_object, subelements]`.

The second element is optional, so it can be set to `None`,
and then the second element will be converted to an empty list,
`[target_object, []]`, as required by the Label's underlying `Target`
property.
Attach Issues:
mod - src/Mod/Draft/draftguitools/gui_labels.py Diff File
mod - src/Mod/Draft/draftmake/make_label.py Diff File

master 8311b1e6

2020-06-07 23:58:13

wandererfan

Details Diff
[Part]Fix bad shape from Fillet

- see 0004285 for similar fix on Chamfer
Attach Issues:
mod - src/Mod/Part/App/FeatureFillet.cpp Diff File

master 652d965d

2020-06-07 23:13:03

uwestoehr


Committer: wandererfan Details Diff
[TD] use new keyboardTracking feature for Detail dialog

Werner finally implemented that FC's spinboxes accept Qt's keyboardTracking. So we can use it now for dialogs like the Detail dialog.
Attach Issues:
mod - src/Mod/TechDraw/Gui/TaskDetail.cpp Diff File
mod - src/Mod/TechDraw/Gui/TaskDetail.ui Diff File

master f6ae7c27

2020-06-07 23:04:51

Gabriel Wicke


Committer: GitHub Details Diff
Merge branch 'master' into optimizeLinearSegments_fix
Attach Issues:
mod - src/Mod/PartDesign/App/FeatureBase.cpp Diff File

master 7c654878

2020-06-07 22:59:51

Gabriel Wicke

Details Diff
Path: Fix for optimizeLinearSegments

Reduce cumulative error by holding onto the original point in a sequence
of linear optimizations. In testing, this fixes artifacts I have seen on
very finely sampled paths with very gradual curvature.

Further improvements are needed for this optimization, but at least this
change avoids a regression over the status quo.
Attach Issues:
mod - src/Mod/Path/PathScripts/PathSurface.py Diff File

master c8ce1283

2020-06-07 22:59:46

wmayer

Details Diff
PartDesign: [skip ci] fix typo
Attach Issues:
mod - src/Mod/PartDesign/App/FeatureBase.cpp Diff File

master 9a67154e

2020-06-07 21:38:03

wmayer

Details Diff
Gui: [skip ci] fix bug when keyboard tracking for QuantitySpinBox is disabled and value is changed by mouse wheel or the spin buttons
Attach Issues:
mod - src/Gui/QuantitySpinBox.cpp Diff File
mod - src/Gui/QuantitySpinBox.h Diff File

master 07d40a31

2020-06-07 21:03:49

sliptonic


Committer: GitHub Details Diff
Merge pull request 0003564 from gwicke/more_ambitious_stepover

Path: More ambitious step-over and break optimizations
Attach Issues:
mod - src/Mod/Path/PathScripts/PathSurface.py Diff File
mod - src/Mod/Path/PathScripts/PathSurfaceSupport.py Diff File

master b7ba72bf

2020-06-07 19:41:52

wandererfan


Committer: GitHub Details Diff
Merge pull request 0003579 from WandererFan/prefDirs

[Part]Fix 0004285 Bad Shape from Chamfer
Affected Issues
0004285
mod - src/Mod/Part/App/FeatureChamfer.cpp Diff File
mod - src/Mod/TechDraw/Gui/DlgPrefsTechDrawGeneral.ui Diff File

master 1e117647

2020-06-07 18:58:45

wmayer

Details Diff
[skip ci] include missing boost header
Attach Issues:
mod - src/Mod/Part/Gui/TaskDimension.cpp Diff File
mod - src/Mod/PartDesign/Gui/TaskHoleParameters.cpp Diff File

master 904f3408

2020-06-07 18:56:48

carlopav


Committer: yorik Details Diff
Draft: fixed wrong QT_TRANSLATE_NOOP usage in Draft Objects


.
Attach Issues:
mod - src/Mod/Draft/draftobjects/array.py Diff File
mod - src/Mod/Draft/draftobjects/bezcurve.py Diff File
mod - src/Mod/Draft/draftobjects/block.py Diff File
mod - src/Mod/Draft/draftobjects/bspline.py Diff File
mod - src/Mod/Draft/draftobjects/circle.py Diff File
mod - src/Mod/Draft/draftobjects/clone.py Diff File
mod - src/Mod/Draft/draftobjects/dimension.py Diff File
mod - src/Mod/Draft/draftobjects/draft_annotation.py Diff File
mod - src/Mod/Draft/draftobjects/draftlink.py Diff File
mod - src/Mod/Draft/draftobjects/drawingview.py Diff File
mod - src/Mod/Draft/draftobjects/ellipse.py Diff File
mod - src/Mod/Draft/draftobjects/facebinder.py Diff File
mod - src/Mod/Draft/draftobjects/fillet.py Diff File
mod - src/Mod/Draft/draftobjects/label.py Diff File
mod - src/Mod/Draft/draftobjects/point.py Diff File
mod - src/Mod/Draft/draftobjects/pointarray.py Diff File
mod - src/Mod/Draft/draftobjects/polygon.py Diff File
mod - src/Mod/Draft/draftobjects/rectangle.py Diff File
mod - src/Mod/Draft/draftobjects/shape2dview.py Diff File
mod - src/Mod/Draft/draftobjects/shapestring.py Diff File
mod - src/Mod/Draft/draftobjects/wire.py Diff File
mod - src/Mod/Draft/draftobjects/wpproxy.py Diff File

master 81dd47b0

2020-06-07 18:51:13

paul lee


Committer: yorik Details Diff
[ArchWall] ArchWall Offset should now works with Base as Sketch
Attach Issues:
mod - src/Mod/Arch/ArchWall.py Diff File
mod - src/Mod/Draft/draftgeoutils/offsets.py Diff File

master 102e9e5c

2020-06-07 17:33:56

wandererfan


Committer: GitHub Details Diff
Merge branch 'master' into prefDirs
Attach Issues:
mod - src/App/Expression.cpp Diff File
mod - src/Gui/DlgExpressionInput.cpp Diff File

master 89ddab33

2020-06-07 16:00:35

wmayer

Details Diff
Expression: move handling of invalid quantities (NaN) from FunctionExpression to DlgExpressionInput
Attach Issues:
mod - src/App/Expression.cpp Diff File
mod - src/Gui/DlgExpressionInput.cpp Diff File

master 73f086f7

2020-06-07 15:25:18

wandererfan

Details Diff
[Part]Fix 0004285 Bad Shape from Chamfer

- chamfer was producing invalid shape as output.
fix uses shapefix to correct invalid surface/face.
Affected Issues
0004285
mod - src/Mod/Part/App/FeatureChamfer.cpp Diff File

master 200c7c7e

2020-06-07 15:21:37

wmayer

Details Diff
[skip ci] include missing boost header
Attach Issues:
mod - src/Gui/DAGView/DAGView.cpp Diff File
mod - src/Mod/Sketcher/Gui/TaskSketcherGeneral.cpp Diff File

master 7a87f8f8

2020-06-07 14:10:51

lambda


Committer: yorik Details Diff
Arch: Fix placement of Space objects imported from ArchiCAD

Any space objects imported from ArchiCAD (via IFC) are rotated
by 90° around the global z-Axis. When turning the same base
shape into an other Arch object like Wall or Slab, no such error
happens.

Turns out the shape creation in Space objects is handled
differently then in other Arch objects and just copying the usual
method fixes this. I have no idea why this makes a difference.

To document why this change is necessary, a test cases is added.
Upon editing TestArch.py a number of trailing spaces have been
removed accidentally.
Attach Issues:
mod - src/Mod/Arch/ArchSpace.py Diff File
mod - src/Mod/Arch/TestArch.py Diff File

master 0a8c6e36

2020-06-07 13:54:34

wmayer

Details Diff
[skip ci] include missing boost header
Attach Issues:
mod - src/App/GroupExtension.cpp Diff File
mod - src/App/Link.cpp Diff File

master d693ff13

2020-06-07 12:57:05

wandererfan

Details Diff
[TD]Fix preference directory pickers
Attach Issues:
mod - src/Mod/TechDraw/Gui/DlgPrefsTechDrawGeneral.ui Diff File

master c0971eb5

2020-06-07 12:52:13

Reinier Heeres


Committer: yorik Details Diff
Fix saving of DXF files (python3)

- Python3 does not allow to write strings to a file opened as "wb"; it
expects bytes instead. Since ASCII DXF files are written using strings,
the file should be opened as "w". Should be ok for python2 as well.
- See also issue 003862, https://tracker.freecadweb.org/view.php?id=3862
Attach Issues:
mod - src/Mod/Draft/importDXF.py Diff File

master e9119741

2020-06-07 12:25:32

wmayer

Details Diff
App: [skip ci] handle XMLAttributeError in Document::readObjects
Attach Issues:
mod - src/App/Document.cpp Diff File
 First  Prev  1 2 3 ... 60 61 62 63 64 65 66 ... 120 ... 180 ... 240 ... 300 ... 360 ... 420 ... 480 ... 540 ... 581 582 583  Next  Last