Changesets: FreeCAD
master 30fcddae 2020-12-28 15:37:33 Committer: wwmayer Details Diff |
[TD] fix bug with angular and small values * angular as reported here: https://forum.freecadweb.org/viewtopic.php?f=35&t=53473&start=10#p461507 * small values: since we convert to e.g. mm, we must then not output e.g. 'µm' * also a code optimization, fix a typo, removal of a meanwhile misleading comment |
||
mod - src/Mod/TechDraw/App/DrawViewDimension.cpp | Diff File | ||
master cfebd3f1 2020-12-28 12:58:41 luz paz Committer: berndhahnebach Details Diff |
FEM: remote superfluous double semicolons [skip ci] | ||
mod - src/Mod/Fem/Gui/TaskFemConstraintContact.cpp | Diff File | ||
mod - src/Mod/Fem/Gui/TaskFemConstraintDisplacement.cpp | Diff File | ||
mod - src/Mod/Fem/Gui/TaskFemConstraintFixed.cpp | Diff File | ||
mod - src/Mod/Fem/Gui/TaskFemConstraintFluidBoundary.cpp | Diff File | ||
mod - src/Mod/Fem/Gui/TaskFemConstraintForce.cpp | Diff File | ||
mod - src/Mod/Fem/Gui/TaskFemConstraintHeatflux.cpp | Diff File | ||
mod - src/Mod/Fem/Gui/TaskFemConstraintInitialTemperature.cpp | Diff File | ||
mod - src/Mod/Fem/Gui/TaskFemConstraintPlaneRotation.cpp | Diff File | ||
mod - src/Mod/Fem/Gui/TaskFemConstraintPressure.cpp | Diff File | ||
mod - src/Mod/Fem/Gui/TaskFemConstraintPulley.cpp | Diff File | ||
mod - src/Mod/Fem/Gui/TaskFemConstraintTemperature.cpp | Diff File | ||
mod - src/Mod/Fem/Gui/TaskFemConstraintTransform.cpp | Diff File | ||
master 97bbc459 2020-12-28 12:56:45 luz paz Committer: berndhahnebach Details Diff |
FEM: z88 solver function typos [skip ci] | ||
mod - src/Mod/Fem/femsolver/z88/writer.py | Diff File | ||
master 4327243a 2020-12-28 12:53:47 luz paz Committer: abdullahtahiriyo Details Diff |
Sketcher: Fix typos and code linting [skip ci] | ||
mod - src/Mod/Sketcher/App/planegcs/GCS.cpp | Diff File | ||
master 472168fc 2020-12-28 12:50:51 luz paz Committer: abdullahtahiriyo Details Diff |
Fix typos [skip ci] Typos ffound via `codespell v2.1.dev0` Also includes fixes in deprecated code of `src/Mod/Assembly` |
||
mod - src/App/ApplicationPy.cpp | Diff File | ||
mod - src/App/DocumentObject.h | Diff File | ||
mod - src/Gui/ApplicationPy.cpp | Diff File | ||
mod - src/Mod/Assembly/App/Product.h | Diff File | ||
mod - src/Mod/Assembly/Gui/ViewProviderProduct.cpp | Diff File | ||
mod - src/Mod/Assembly/Gui/ViewProviderProductRef.cpp | Diff File | ||
mod - src/Mod/Cam/App/ConvertDyna.cpp | Diff File | ||
mod - src/Mod/Part/App/TopoShapeFacePy.xml | Diff File | ||
mod - src/Mod/PartDesign/App/json.hpp | Diff File | ||
mod - src/Mod/Sketcher/App/SketchObject.cpp | Diff File | ||
mod - src/XDGData/org.freecadweb.FreeCAD.appdata.xml.in | Diff File | ||
master b318426c 2020-12-28 10:36:24 Details Diff |
Sketcher: fix -Wextra-semi | ||
mod - src/Mod/Sketcher/App/planegcs/Geo.h | Diff File | ||
master ae0742c7 2020-12-28 10:33:02 Details Diff |
Sketcher: fix layout by removing minimumSize property from labels | ||
mod - src/Mod/Sketcher/Gui/SketcherSettingsColors.ui | Diff File | ||
master bd1f06cf 2020-12-28 01:07:59 Committer: wwmayer Details Diff |
[TD] cleanup preferences as discussed here: https://forum.freecadweb.org/viewtopic.php?f=35&t=53680&p=461356#p461349 * change default tolerance scale to 0.8 * the tolerance scale is directly applied, thus it must have non-italic label * move tolerance scale to "Dimensions" tab * move Fuzz settings to "Advanced" tab * move Conventions to General tab since e.g. the projection angle is an important general setting * add a note for the label font that this is also used for dimensions and that it there only has an effect for new ones * use more useful step size of 0.1 for some scaling spinboxes * sort UI fields in the C++ code to avoid doubled or missing entries (there were 2 doubled entries) * uniform width of all preferences dialogs * better alignment for the HLR dialog |
||
mod - src/Mod/TechDraw/Gui/DlgPrefsTechDrawAdvanced.ui | Diff File | ||
mod - src/Mod/TechDraw/Gui/DlgPrefsTechDrawAdvancedImp.cpp | Diff File | ||
mod - src/Mod/TechDraw/Gui/DlgPrefsTechDrawAnnotation.ui | Diff File | ||
mod - src/Mod/TechDraw/Gui/DlgPrefsTechDrawColors.ui | Diff File | ||
mod - src/Mod/TechDraw/Gui/DlgPrefsTechDrawDimensions.ui | Diff File | ||
mod - src/Mod/TechDraw/Gui/DlgPrefsTechDrawDimensionsImp.cpp | Diff File | ||
mod - src/Mod/TechDraw/Gui/DlgPrefsTechDrawGeneral.ui | Diff File | ||
mod - src/Mod/TechDraw/Gui/DlgPrefsTechDrawGeneralImp.cpp | Diff File | ||
mod - src/Mod/TechDraw/Gui/DlgPrefsTechDrawHLR.ui | Diff File | ||
mod - src/Mod/TechDraw/Gui/DlgPrefsTechDrawScale.ui | Diff File | ||
mod - src/Mod/TechDraw/Gui/DlgPrefsTechDrawScaleImp.cpp | Diff File | ||
master 079b8ff5 2020-12-27 23:10:28 Committer: wwmayer Details Diff |
[TD] DrawViewDimension Tolerances, print zero tolerances without plus sign and decimals. | ||
mod - src/Mod/TechDraw/App/DrawViewDimension.cpp | Diff File | ||
master dbedb216 2020-12-27 14:17:23 Details Diff |
[Spreadsheet] Only evaluate cell values when prefixed with '=' This commit only changes the user interaction with spreadsheet and does not affect backwards compatibility (as valid cell expressions are prefixed with '=' when serialized). This fixes [0004156](https://tracker.freecadweb.org/view.php?id=4156), which is discussed in the forum thread: https://forum.freecadweb.org/viewtopic.php?f=3&t=39665 There has been additional logic added to handle numbers and simple fractions without using '='. The behaviour is what is expected by the spreadsheet test cases and in line with how other spreadsheet software works. The '-prefix can still be used to force the input to be handled as as string instead. Example of numbers and fractions handled are: 3 2mm 1/8 1mm/2 1/2mm 2/m 1mm/2s More complex expressions are not handled without '=' and will be stored as strings instead, for example: 2 / 3 / 2 1 + 1/3 |
||
mod - src/Mod/Spreadsheet/App/Cell.cpp | Diff File | ||
master 75f78f94 2020-12-27 11:52:08 bitacovir Committer: wwmayer Details Diff |
Replace SVG icons of six Std View commands | ||
mod - src/Gui/CommandView.cpp | Diff File | ||
add - src/Gui/Icons/Std_SetAppearance.svg | Diff File | ||
add - src/Gui/Icons/Std_ViewIvStereoInterleavedColumns.svg | Diff File | ||
add - src/Gui/Icons/Std_ViewIvStereoInterleavedRows.svg | Diff File | ||
add - src/Gui/Icons/Std_ViewIvStereoOff.svg | Diff File | ||
add - src/Gui/Icons/Std_ViewIvStereoQuadBuff.svg | Diff File | ||
add - src/Gui/Icons/Std_ViewIvStereoRedGreen.svg | Diff File | ||
mod - src/Gui/Icons/resource.qrc | Diff File | ||
master 08297e52 2020-12-27 08:59:07 J-Dunn Committer: wmayer Details Diff |
Path: fix unnecessary copy on read for Command.parameters dict Contents of underlying c++ std::map data is copied to a new PyDict on every read. This is contrary to expected python behaviour which would normally just return the pointer to a python object and increment the reference counter for it. This was leading to massive redundant deletion and copying in all post processors which reference this variable in a nested loop. This PR adds a permanent dict member to the class and keeps track of changes to avoid unnecessary copying. |
||
mod - src/Mod/Path/App/CommandPy.xml | Diff File | ||
mod - src/Mod/Path/App/CommandPyImp.cpp | Diff File | ||
master 67e5f9c3 2020-12-27 07:19:23 Details Diff |
Sketcher: Make select-constraint select-elements mode consistent with select-element select-constraint ====================================================================================================== https://forum.freecadweb.org/viewtopic.php?f=13&t=53515&p=461142#p460687 When using select-constraint then select elements, allow both point-line-point and point-point-line. |
||
mod - src/Mod/Sketcher/Gui/CommandConstraints.cpp | Diff File | ||
master 82ec99db 2020-12-27 05:45:31 Committer: wwmayer Details Diff |
[TD] fix regression for balloon text separators as reported here: https://forum.freecadweb.org/viewtopic.php?f=35&t=53664 the balloon text separation no longer works. The regression was introduced by commit 05577c267 . The mistake thereby was that the textHeight is already handled before the separators and that rectangular balloons behave differently because of the separator feature. |
||
mod - src/Mod/TechDraw/Gui/QGIViewBalloon.cpp | Diff File | ||
master a9da6194 2020-12-27 04:35:49 Committer: wwmayer Details Diff |
[TD] update balloon dialog 2 weeks ago the properties EndTypeScale and LineVisible were added but not to the dialog. This PR adds them t the balloon dialog- It also took the opportunity to cleanup the code: - add missing tooltips - uniform tooltips in App and Gui - uniform the UI element names |
||
mod - src/Mod/TechDraw/App/DrawViewBalloon.cpp | Diff File | ||
mod - src/Mod/TechDraw/Gui/TaskBalloon.cpp | Diff File | ||
mod - src/Mod/TechDraw/Gui/TaskBalloon.h | Diff File | ||
mod - src/Mod/TechDraw/Gui/TaskBalloon.ui | Diff File | ||
mod - src/Mod/TechDraw/Gui/ViewProviderBalloon.cpp | Diff File | ||
master 714a7165 2020-12-27 03:06:27 Committer: wmayer Details Diff |
[TD] handle equal tolerances correctly the common rule is that if a dimension has equal over- and undertolerance, they are output on the same line as the dimension concatenated using the ± character. This PR does this. Note that this is not just cosmetics, it is even standardized in the GD&T norms. also: * use one format specifier for tolerances since the norms don't allow a different format for the over- and the undertolerance * some code optimizations like a self-explaining function name, remove unnecessary/outdated comments |
||
mod - src/Mod/TechDraw/App/DrawViewDimension.cpp | Diff File | ||
mod - src/Mod/TechDraw/App/DrawViewDimension.h | Diff File | ||
mod - src/Mod/TechDraw/Gui/QGIViewDimension.cpp | Diff File | ||
mod - src/Mod/TechDraw/Gui/QGIViewDimension.h | Diff File | ||
master b12bf375 2020-12-26 21:03:40 Details Diff |
Updated layout | ||
mod - src/Mod/Path/Gui/Resources/panels/DressUpLeadInOutEdit.ui | Diff File | ||
mod - src/Mod/Path/PathScripts/PathDressupLeadInOut.py | Diff File | ||
master c6780036 2020-12-26 20:11:27 Details Diff |
Panel Start at creation | ||
mod - src/Mod/Path/PathScripts/PathDressupLeadInOut.py | Diff File | ||
master 38cafc57 2020-12-26 17:48:21 luz paz Committer: abdullahtahiriyo Details Diff |
Sketcher: typo in function name | ||
mod - src/Mod/Sketcher/App/SketchObject.cpp | Diff File | ||
master 6b017f9a 2020-12-26 16:46:20 Committer: abdullahtahiriyo Details Diff |
Sketcher: ViewProvider - fix crash due to invalidated geomety pointer ===================================================================== Finish checks with geometry pointer before calling initTemporaryMove(), as the pointer may change as a result of the solve() operation. |
||
mod - src/Mod/Sketcher/Gui/ViewProviderSketch.cpp | Diff File | ||
master c2ab5131 2020-12-26 16:16:24 Committer: abdullahtahiriyo Details Diff |
GCS: Return a zero sized reduced Jacobian if only driven constraints present ============================================================================= The reduced Jacobian defaults to the size of the full Jacobian, where driven constraints and parameters are not considered to build the reduced Jacobian and thus empty rows remain. This is generally not a problem as QR decomposition ignores this rows, except in case where only driven constraints exist. In such a case no QR decomposition is necessary, and in fact relying on the size of the QR decomposition leads to the incorrect result that the sketch is fully constraint, when the opposite is true. This commit resizes an effectively empty reduced Jacobian to avoid this issue. Fixes the problem that a line with a single reference constraint is shown as fully constraint. |
||
mod - src/Mod/Sketcher/App/planegcs/GCS.cpp | Diff File | ||
master 72ec38be 2020-12-26 12:49:56 Committer: GitHub Details Diff |
Merge pull request 0004161 from bryanbendall/adaptive-work Path: Adaptive work |
||
mod - src/Mod/Path/PathScripts/PathAdaptive.py | Diff File | ||
mod - src/Mod/Path/PathScripts/PathAdaptiveGui.py | Diff File | ||
mod - src/Mod/Path/libarea/Adaptive.cpp | Diff File | ||
mod - src/Mod/Path/libarea/Adaptive.hpp | Diff File | ||
mod - src/Mod/Path/libarea/PythonStuff.cpp | Diff File | ||
master cc29af4d 2020-12-25 14:17:13 Committer: wmayer Details Diff |
[Sketch] remove unused code fixes bug 0004522 as discussed in https://forum.freecadweb.org/viewtopic.php?f=10&t=53587&p=460823#p460777 also remove superfluous verticalSpacer |
Affected Issues 0004522 |
|
mod - src/Mod/Sketcher/Gui/SketcherSettings.cpp | Diff File | ||
mod - src/Mod/Sketcher/Gui/SketcherSettingsColors.ui | Diff File | ||
master 59ec3cb1 2020-12-25 11:42:03 Committer: wwmayer Details Diff |
PartDesign: New features AdditiveHelix and SubtractiveHelix These features, based on the code for the Pipe class, allow the user to simply create a helical sweep within PartDesign workbench. Sample application is threads, springs, coils, augers, etc. Also, remove needless requirement for positive cone angle on helixes. Thanks to @bitacovir for helping with the icons Thanks to @chennes for review Thanks to @vosk for review Thanks to @wwmayer for review Enforce that links stay within scope for ProfileBased features This also ensures that the Body itself is not used for creating features within the body, causing a "Graph not a DAG" error. |
||
mod - src/Mod/Part/App/TopoShape.cpp | Diff File | ||
mod - src/Mod/PartDesign/App/AppPartDesign.cpp | Diff File | ||
mod - src/Mod/PartDesign/App/Body.cpp | Diff File | ||
mod - src/Mod/PartDesign/App/Body.h | Diff File | ||
mod - src/Mod/PartDesign/App/CMakeLists.txt | Diff File | ||
add - src/Mod/PartDesign/App/FeatureHelix.cpp | Diff File | ||
add - src/Mod/PartDesign/App/FeatureHelix.h | Diff File | ||
mod - src/Mod/PartDesign/App/FeatureSketchBased.cpp | Diff File | ||
mod - src/Mod/PartDesign/App/FeatureSketchBased.h | Diff File | ||
mod - src/Mod/PartDesign/Gui/AppPartDesignGui.cpp | Diff File | ||
mod - src/Mod/PartDesign/Gui/CMakeLists.txt | Diff File | ||
mod - src/Mod/PartDesign/Gui/Command.cpp | Diff File | ||
mod - src/Mod/PartDesign/Gui/Resources/PartDesign.qrc | Diff File | ||
add - src/Mod/PartDesign/Gui/Resources/icons/PartDesign_Additive_Helix.svg | Diff File | ||
add - src/Mod/PartDesign/Gui/Resources/icons/PartDesign_Subtractive_Helix.svg | Diff File | ||
add - src/Mod/PartDesign/Gui/TaskHelixParameters.cpp | Diff File | ||
add - src/Mod/PartDesign/Gui/TaskHelixParameters.h | Diff File | ||
add - src/Mod/PartDesign/Gui/TaskHelixParameters.ui | Diff File | ||
add - src/Mod/PartDesign/Gui/ViewProviderHelix.cpp | Diff File | ||
add - src/Mod/PartDesign/Gui/ViewProviderHelix.h | Diff File | ||
mod - src/Mod/PartDesign/Gui/ViewProviderSketchBased.cpp | Diff File | ||
mod - src/Mod/PartDesign/Gui/ViewProviderSketchBased.h | Diff File | ||
mod - src/Mod/PartDesign/Gui/Workbench.cpp | Diff File | ||
master 1d56289c 2020-12-25 08:01:21 Committer: abdullahtahiriyo Details Diff |
Sketcher: restric ViewProviderSketch access to the solver ========================================================= -> Split read and read/write operations New interface to access the solver object (Sketch) of SketchObject is now read only (const): const Sketcher::Sketch &getSolvedSketch(void) const; -> Encapsulate solver r/w access in SketchObject Rationale: - r/w access (access to non-const functions of the solver) leads to unsynchronised solver status. - Before this commit there was a non-enforceable shared responsibility between ViewProviderSketch and SketchObject. - This commit centralises r/w access in SketchObject and SketchObject takes responsibility for doing whatever necessary so that the solver is synchronised as appropriate. - For read-only access (const functions) it is possible to use at ViewProviderSketch getSolvedSketch() returning a const reference to the solver object. - As it regards the advanced solver configuration dialog, it has been modified to configure by const-casting that reference. This is not optimal, but it is deemed acceptable, because it should be rewritten sooner or later to include only useful information and the configuration probably centralised in an individual configuration object, possibly compatible with several solvers (e.g. DeepSOIC's ConstraintSolver too). |
||
mod - src/Mod/Sketcher/App/SketchObject.h | Diff File | ||
mod - src/Mod/Sketcher/Gui/TaskSketcherSolverAdvanced.cpp | Diff File | ||
mod - src/Mod/Sketcher/Gui/ViewProviderSketch.cpp | Diff File | ||
mod - src/Mod/Sketcher/Gui/ViewProviderSketch.h | Diff File |