FreeCADChangesets: FreeCAD
|
master 45eea3d9 2021-02-03 09:45:22 luz paz Committer: wwmayer Details Diff |
Fix various typos [skip ci] Found via codespell v2.1.dev0 ``` codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,apoints,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./build/doc/SourceDocu ``` |
||
| mod - src/Base/core-base.dox | Diff File | ||
| mod - src/Mod/Path/Tools/README.md | Diff File | ||
| mod - src/Mod/Sketcher/App/planegcs/Constraints.cpp | Diff File | ||
|
master 3a656d85 2021-02-03 05:27:34 Details Diff |
Sketcher: UI Constraint Creation - PointOnObject + Tangency on edge constraint substitution ============================================================================================ On creation of a constraint from the UI (toolbar/menu): 1. if a PointOnObject constraint preexisted the addition of an edge-to-edge tangency, substitute it with a point-to-edge tangency. 2. if an edge-to-edge tangency preexisted, addition of a PointOnObject results in a substitution of the edge-to-edge tangency with an edge-to-curve tangency. Bonus: - Refactor of this with preexisting coincident+tangent substitution. - Activate both substitutions in continuous constraint addition mode. |
||
| mod - src/Mod/Sketcher/Gui/CommandConstraints.cpp | Diff File | ||
| mod - src/Mod/Sketcher/Gui/CommandConstraints.h | Diff File | ||
|
master 9c9244df 2021-02-03 04:21:45 Committer: wmayer Details Diff |
Guard against segfaults due to out-of-order dialog deletion | ||
| mod - src/Gui/TaskView/TaskView.cpp | Diff File | ||
|
master 400b25c0 2021-02-03 02:49:56 Committer: wwmayer Details Diff |
[TD] fix color change for dimensions This PR fixes issue C reported here: https://forum.freecadweb.org/viewtopic.php?f=35&t=55008#p472939 - the changed color must also be applied to the dimension line and arrows |
||
| mod - src/Mod/TechDraw/Gui/QGIPrimPath.cpp | Diff File | ||
|
master cc3a30a2 2021-02-03 00:06:44 Committer: wwmayer Details Diff |
[PD] fix typo in iso7046.json This mistake was introduced by me in commit 4ab3c955 |
||
| mod - src/Mod/PartDesign/Resources/Hole/iso7046.json | Diff File | ||
|
master 7a838535 2021-02-02 20:51:11 Details Diff |
Part: offer all supported STEP schemes by OCC in a combo box | ||
| mod - src/Mod/Import/Gui/AppImportGuiPy.cpp | Diff File | ||
| mod - src/Mod/Part/App/ImportStep.h | Diff File | ||
| mod - src/Mod/Part/Gui/DlgImportExportStep.ui | Diff File | ||
| mod - src/Mod/Part/Gui/DlgSettingsGeneral.cpp | Diff File | ||
|
master d3ddbe85 2021-02-02 17:04:44 Committer: wwmayer Details Diff |
PartDesign: Add true threads to Hole - Thread runout according to DIN 76-1 - Through all length updated to be calculated based on bounding box - New properties: ModelThread, ThreadDepthType, ThreadDepth, UseCustomThreadClearance, CustomThreadClearance - Rename Old but unused parameters related to thread modeling. - Functionality exposed in UI |
||
| mod - src/Mod/PartDesign/App/FeatureHole.cpp | Diff File | ||
| mod - src/Mod/PartDesign/App/FeatureHole.h | Diff File | ||
| mod - src/Mod/PartDesign/Gui/TaskHoleParameters.cpp | Diff File | ||
| mod - src/Mod/PartDesign/Gui/TaskHoleParameters.h | Diff File | ||
| mod - src/Mod/PartDesign/Gui/TaskHoleParameters.ui | Diff File | ||
|
master 078160ea 2021-02-02 16:49:44 Details Diff |
TechDraw: Exposed GeomHatch functionality to Python in TechDraw.makeGeomHatch() | ||
| mod - src/Mod/TechDraw/App/AppTechDrawPy.cpp | Diff File | ||
|
master d02a0d55 2021-02-02 13:01:43 Committer: GitHub Details Diff |
Merge pull request 0004331 from chennes/openSCADFix [Draft] OpenSCAD/DXF error: fix DXF import with no layers |
||
| mod - src/Mod/Draft/importDXF.py | Diff File | ||
| mod - src/Mod/OpenSCAD/OpenSCAD2Dgeom.py | Diff File | ||
|
master 253ef2a9 2021-02-02 12:59:09 Committer: GitHub Details Diff |
Merge pull request 0004346 from chennes/validateStartHTMLWithW3C [Start] Modify generated HTML to comply with W3C Validator Recommendations |
||
| mod - src/Mod/Start/StartPage/StartPage.html | Diff File | ||
| mod - src/Mod/Start/StartPage/StartPage.py | Diff File | ||
| mod - src/Mod/Start/TestStart/TestStartPage.py | Diff File | ||
|
master bdc07a1d 2021-02-02 10:52:36 Committer: GitHub Details Diff |
Merge pull request 0004351 from chennes/fixSurfaceDeleteShortcuts [Surface] Fix task panel Delete shortcut use to use Widget context |
||
| mod - src/Mod/Surface/Gui/TaskFilling.cpp | Diff File | ||
| mod - src/Mod/Surface/Gui/TaskFillingEdge.cpp | Diff File | ||
| mod - src/Mod/Surface/Gui/TaskFillingVertex.cpp | Diff File | ||
|
master 45dd1a7f 2021-02-02 03:11:10 Committer: wmayer Details Diff |
fix issue reported by @chennes also fix annoying variable naming - different variables representing different types should not have the same name also update a comment according to depending PRs |
||
| mod - src/Mod/PartDesign/App/FeatureHole.cpp | Diff File | ||
| mod - src/Mod/PartDesign/Gui/TaskHoleParameters.cpp | Diff File | ||
|
master 612eba1b 2021-02-02 01:40:33 Details Diff |
Fix Surface task panel shortcut use to use Widget context The Delete key shortcut of the three different panels in the Surface Workbench TaskFilling sidebar conflicted between the panels if multiple were showing. This is resolved by making the QAction's context the widget, rather than the window. |
||
| mod - src/Mod/Surface/Gui/TaskFilling.cpp | Diff File | ||
| mod - src/Mod/Surface/Gui/TaskFillingEdge.cpp | Diff File | ||
| mod - src/Mod/Surface/Gui/TaskFillingVertex.cpp | Diff File | ||
|
master 5e07d708 2021-02-01 06:26:18 Committer: wwmayer Details Diff |
Remove extraneous lines from export Corrects a merge issue from an earlier PR: the removed lines are redundant. |
||
| mod - src/Gui/Application.cpp | Diff File | ||
|
master 1c58c3b6 2021-02-01 05:11:40 Committer: wmayer Details Diff |
[PD] hole fix custom cut handling This PR is based on PR 0004344 and a spin-off of PR 0004337. It fixes: We have normed screw head cuts. These values can be overridden but we must store the info about the overriding. Why? - because when you have e.g. made a custom change to a normed countersink and then change to another countersink norm, you would either not get the values defined in the norm or you get these values but loose e.g. your depth settings |
||
| mod - src/Mod/PartDesign/App/FeatureHole.cpp | Diff File | ||
| mod - src/Mod/PartDesign/App/FeatureHole.h | Diff File | ||
| mod - src/Mod/PartDesign/Gui/TaskHoleParameters.cpp | Diff File | ||
| mod - src/Mod/PartDesign/Gui/TaskHoleParameters.h | Diff File | ||
| mod - src/Mod/PartDesign/Gui/TaskHoleParameters.ui | Diff File | ||
|
master 589cec2d 2021-02-01 04:19:11 Details Diff |
Draft: Add global mode to enter points - fixes 0004108 |
Affected Issues 0004108 |
|
| mod - src/Mod/Draft/DraftGui.py | Diff File | ||
| mod - src/Mod/Draft/Resources/ui/preferences-draftinterface.ui | Diff File | ||
|
master 1958e30f 2021-02-01 04:13:47 Details Diff |
Modify Start HTML to be valid HTML Using the W3C validator, a number of minor issues were found with the Start page HTML. Those items were: * Missing language setting on the body of the document * Deprecated attributes set for the style and script tags * Image tags require alt text * List tags can only contain list items * All file:/// URLs must not contain backslashes, even on Windows |
||
| mod - src/Mod/Start/StartPage/StartPage.html | Diff File | ||
| mod - src/Mod/Start/StartPage/StartPage.py | Diff File | ||
|
master 768264b7 2021-02-01 03:22:25 Details Diff |
Draft: Use function-specific icons in the taskbar | ||
| mod - src/Mod/Draft/draftguitools/gui_base_original.py | Diff File | ||
| mod - src/Mod/Draft/draftguitools/gui_beziers.py | Diff File | ||
| mod - src/Mod/Draft/draftguitools/gui_dimensions.py | Diff File | ||
| mod - src/Mod/Draft/draftguitools/gui_ellipses.py | Diff File | ||
| mod - src/Mod/Draft/draftguitools/gui_lines.py | Diff File | ||
| mod - src/Mod/Draft/draftguitools/gui_mirror.py | Diff File | ||
| mod - src/Mod/Draft/draftguitools/gui_move.py | Diff File | ||
| mod - src/Mod/Draft/draftguitools/gui_points.py | Diff File | ||
| mod - src/Mod/Draft/draftguitools/gui_polygons.py | Diff File | ||
| mod - src/Mod/Draft/draftguitools/gui_rectangles.py | Diff File | ||
| mod - src/Mod/Draft/draftguitools/gui_rotate.py | Diff File | ||
| mod - src/Mod/Draft/draftguitools/gui_scale.py | Diff File | ||
| mod - src/Mod/Draft/draftguitools/gui_shapestrings.py | Diff File | ||
| mod - src/Mod/Draft/draftguitools/gui_splines.py | Diff File | ||
| mod - src/Mod/Draft/draftguitools/gui_stretch.py | Diff File | ||
|
master 7b9c9d4f 2021-01-31 23:24:49 Details Diff |
Add tests for Start Page HTML validity This test is in two parts: first the generated HTML is sanitized to remove any potentially sensitive information (e.g. filenames, authors, document info, etc.) and is then sent to the W3C Validator service at https://validator.w3.org/nu. The results are interrogated and if any errors or warnings are returned, the test fails. If the site cannot be reached this is NOT treated as a test failure. Second, the actual (unsanitized) filenames are checked for validity: the HTML standard prohibits backslashes in URLs, even if the URL refers to a local file on a system that uses backslashes as a path separator (e.g. Windows). This would have been caught by the W3C Validator if we had not sanitized the filenames. |
||
| mod - src/Mod/Start/TestStart/TestStartPage.py | Diff File | ||
|
master c676c073 2021-01-31 21:53:29 Committer: wmayer Details Diff |
[PD] fix UTS clearance holes This PR is based on PR 0004343 and a spin-off of PR 0004337. It fixes: - the bug that we did not use the normed clearance hole diameters for UTS holes - missing recompute when changing existing hole from Metric to UTS type |
||
| mod - src/Mod/PartDesign/App/FeatureHole.cpp | Diff File | ||
| mod - src/Mod/PartDesign/App/FeatureHole.h | Diff File | ||
| mod - src/Mod/PartDesign/Gui/TaskHoleParameters.cpp | Diff File | ||
|
master 7eb9b5ed 2021-01-31 20:58:22 Committer: wwmayer Details Diff |
[PD] hole dialog UI fixes This PR is the first in a series of probably 3 PRs to fix known hole dialog bugs. This one fixes: - the .ui file issues - readonly status issues of some widgets/properties (e.g. when the hole is through all, disable drill point settings) - the bug that updateHoleCutParams() overwrote the previously correctly determined hole diameter - just a trifle: change a function name to fit into the naming scheme |
||
| mod - src/Mod/PartDesign/App/FeatureHole.cpp | Diff File | ||
| mod - src/Mod/PartDesign/Gui/TaskHoleParameters.cpp | Diff File | ||
| mod - src/Mod/PartDesign/Gui/TaskHoleParameters.h | Diff File | ||
| mod - src/Mod/PartDesign/Gui/TaskHoleParameters.ui | Diff File | ||
|
master 9f07b72b 2021-01-31 20:23:57 Details Diff |
[PATH] Limited cone angle for adaptiv helix | ||
| mod - src/Mod/Path/PathScripts/PathAdaptive.py | Diff File | ||
| mod - src/Mod/Path/PathScripts/PathAdaptiveGui.py | Diff File | ||
|
master d32631cc 2021-01-31 19:24:59 Details Diff |
[Draft] Add better error message in get_svg for direction An AttributeError is raised when `direction=Vector(0,0,0)` and obj is an Arch::Space on line: https://github.com/FreeCAD/FreeCAD/blob/bead9bb9381d039d6dda438b07e30dace7cf33ae/src/Mod/Draft/draftfunctions/svg.py#L799 This patch checks if early on if the direction vector and raises a ValueError with a description of what has gone wrong. A caveat with this solution is that this new behaviour might break old code which depends on that invalid directions can be used. |
||
| mod - src/Mod/Draft/draftfunctions/svg.py | Diff File | ||
| mod - src/Mod/Draft/drafttests/test_svg.py | Diff File | ||
|
master 93a956e7 2021-01-31 15:26:22 Details Diff |
[PD] [skip ci] fix alignment in pad dialog just a minor UI issue: when you decrease the width of the pad dialog (e.g. because you have a small screen), the alignment of the widgets is lost. This fixes it by grouping the widgets in a grid. |
||
| mod - src/Mod/PartDesign/Gui/TaskPadParameters.ui | Diff File | ||
|
master 4ab3c955 2021-01-30 23:32:23 Committer: wwmayer Details Diff |
[PD] correct hole cut definitions I was able to get the norms and could update the definitions accordingly. For example in the ISO 10462, sizes smaller than M3 are not defined and your definition files should only contain what is really defined. |
||
| mod - src/Mod/PartDesign/Resources/Hole/iso10642.json | Diff File | ||
| mod - src/Mod/PartDesign/Resources/Hole/iso7046.json | Diff File | ||
