Changesets: FreeCAD

master 690cc3e1

2020-10-24 13:37:04

wmayer

Details Diff
Gui: [skip ci] let view provider to decide to whether open a transaction on double-click

The sketcher view provider doesn't need a transaction on double-click or otherwise shows a useless entry in the undo dialog which when undoing leads to weird behaviour
Attach Issues:
mod - src/Gui/Tree.cpp Diff File
mod - src/Gui/ViewProvider.h Diff File
mod - src/Gui/ViewProviderDocumentObject.cpp Diff File
mod - src/Gui/ViewProviderDocumentObject.h Diff File
mod - src/Mod/Sketcher/Gui/ViewProviderSketch.h Diff File

master 73ba3061

2020-10-23 18:50:23

wmayer

Details Diff
App: [skip ci] fix printing warning for recursive calls of Document::_commitTransaction
Attach Issues:
mod - src/App/Document.cpp Diff File

master cda1205c

2020-10-23 17:47:33

wmayer

Details Diff
App: [skip ci] fix possible segmentation fault when performing a transaction after an undo
Attach Issues:
mod - src/App/Document.cpp Diff File

master 9f74b422

2020-10-23 16:04:07

luz paz


Committer: wwmayer Details Diff
Fix various typos [skip-ci]
Attach Issues:
mod - src/Gui/Quarter/Mouse.cpp Diff File
mod - src/Mod/Draft/draftguitools/gui_snapper.py Diff File
mod - src/Mod/Draft/draftmake/make_sketch.py Diff File
mod - src/Mod/Fem/femviewprovider/view_base_femobject.py Diff File
mod - src/Mod/Path/PathScripts/PathToolEdit.py Diff File
mod - src/Mod/Path/PathScripts/PathToolLibraryEditor.py Diff File

master f16f9740

2020-10-23 15:27:41

luz paz


Committer: wwmayer Details Diff
Sketcher: Capitalize opeCommand() text [skip-ci]
Attach Issues:
mod - src/Mod/Sketcher/Gui/CommandConstraints.cpp Diff File

master e73ea7d2

2020-10-23 15:26:53

luz paz


Committer: wwmayer Details Diff
Sketcher: Fix typos [skip-ci]
Attach Issues:
mod - src/Mod/Sketcher/Gui/CommandConstraints.cpp Diff File

master 34154019

2020-10-23 11:43:42

wmayer

Details Diff
Sketcher: [skip ci] fix changing multiplicity of a spline for Windows builds if PCH is enabled
Attach Issues:
mod - src/Mod/Sketcher/Gui/PreCompiled.h Diff File

master aeb0c17e

2020-10-23 09:56:17

wmayer

Details Diff
Sketcher: [skip ci] fix crash when deleting a selected geometry directly with delGeometry()
Attach Issues:
mod - src/Mod/Sketcher/Gui/ViewProviderSketch.cpp Diff File

master 4a8201a2

2020-10-23 09:26:15

wmayer

Details Diff
Sketch: [skip ci] handle possible crashes when decreasing degree of a spline
Attach Issues:
mod - src/Mod/Sketcher/App/SketchObject.cpp Diff File
mod - src/Mod/Sketcher/App/SketchObjectPyImp.cpp Diff File
mod - src/Mod/Sketcher/Gui/CommandSketcherBSpline.cpp Diff File

master fc89f4eb

2020-10-22 22:36:41

wmayer

Details Diff
Sketcher: implement command to decrease degree of a B-spline
Attach Issues:
mod - src/Mod/Sketcher/App/SketchObject.cpp Diff File
mod - src/Mod/Sketcher/App/SketchObject.h Diff File
mod - src/Mod/Sketcher/App/SketchObjectPy.xml Diff File
mod - src/Mod/Sketcher/App/SketchObjectPyImp.cpp Diff File
mod - src/Mod/Sketcher/Gui/CommandSketcherBSpline.cpp Diff File
mod - src/Mod/Sketcher/Gui/Workbench.cpp Diff File

master c5d5d69c

2020-10-22 22:06:31

wmayer

Details Diff
Part: [skip ci] add method to approximate a B-spline curve with a given max. degree
Attach Issues:
mod - src/Mod/Part/App/BSplineCurvePyImp.cpp Diff File
mod - src/Mod/Part/App/Geometry.cpp Diff File
mod - src/Mod/Part/App/Geometry.h Diff File

master 0001cb0f

2020-10-22 17:32:10

wmayer

Details Diff
Sketcher: [skip ci] remove AutoTransaction from ViewProviderSketch::mouseButtonPressed because it breaks the open/commit transaction logic
Attach Issues:
mod - src/Mod/Sketcher/Gui/ViewProviderSketch.cpp Diff File

master a2a1f04f

2020-10-22 14:58:39

wmayer

Details Diff
Sketcher: [skip ci] remove superfluous transaction when start/finish editing a sketch
Attach Issues:
mod - src/Mod/Sketcher/Gui/Command.cpp Diff File

master cd4901bf

2020-10-22 14:01:22

wmayer

Details Diff
Sketcher: [skip ci] do not create dialog on heap if not needed to improve exception-safety and reduce possible memory leaks
Attach Issues:
mod - src/Mod/Sketcher/Gui/Command.cpp Diff File
mod - src/Mod/Sketcher/Gui/CommandSketcherTools.cpp Diff File

master ee79991c

2020-10-22 12:16:37

wmayer

Details Diff
Sketcher: fix regression in CmdSketcherValidateSketch
Do not enable the command if another task dialog is still active
Attach Issues:
mod - src/Mod/Sketcher/Gui/Command.cpp Diff File

master 9d362535

2020-10-22 10:43:39

wmayer

Details Diff
Part: [skip ci] use the correct icon for helix and sprial view providers
Attach Issues:
mod - src/Mod/Part/Gui/ViewProviderSpline.cpp Diff File

master 896a1bcb

2020-10-22 01:35:43

uwestoehr


Committer: wwmayer Details Diff
[PD] more holes fixes

- initialization: thread direction only sensible if there is a thread
- initialization: hole diameter can only be changed if there is no profile
- initialization: only enable allowed hole cut parameters
- also for the ISO profiles it is allowed to countersink/bore deeper/less deep
- UI file: add some tooltips (the other changes were done automatically by Qt's designer)
Attach Issues:
mod - src/Mod/PartDesign/App/FeatureHole.cpp Diff File
mod - src/Mod/PartDesign/Gui/TaskHoleParameters.cpp Diff File
mod - src/Mod/PartDesign/Gui/TaskHoleParameters.ui Diff File

master 318312be

2020-10-21 14:03:04

marioalexis


Committer: yorik Details Diff
Draft: Fix logical error in is_line function
Attach Issues:
mod - src/Mod/Draft/DraftGeomUtils.py Diff File
mod - src/Mod/Draft/draftgeoutils/edges.py Diff File

master 33caa1ec

2020-10-21 02:05:19

luz paz


Committer: wwmayer Details Diff
Fix various typos

Found via `codespell v2.0.dev`
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
Attach Issues:
mod - src/Mod/Draft/draftgeoutils/edges.py Diff File
mod - src/Mod/Draft/draftgeoutils/geometry.py Diff File
mod - src/Mod/Draft/draftmake/make_sketch.py Diff File
mod - src/Mod/Part/App/BRepFeat/MakePrismPyImp.cpp Diff File

master ccd89803

2020-10-20 20:15:00

bitacovir


Committer: wwmayer Details Diff
Add SVG icons for two Std commands

Two Std commands do not have icons for the FreeCAD UI (Menu Edit): Std DuplicateSelection, Std_Alignment.
Attach Issues:
mod - src/Gui/CommandDoc.cpp Diff File
add - src/Gui/Icons/Std_Alignment.svg Diff File
add - src/Gui/Icons/Std_DuplicateSelection.svg Diff File
mod - src/Gui/Icons/resource.qrc Diff File

master 72eb41b2

2020-10-20 13:21:09

jreinhardt


Committer: wwmayer Details Diff
Fix macro code processing

I believe this code is currently incorrect, as it makes references to code outside the "if code" block, where it can not be ensured that code is a string. Moving the code processing into this block avoids this issue.

I experienced a stuck Addon Manager, which was caused by an exception

```
File "/usr/share/freecad/Mod/AddonManager/addonmanager_macro.py", line ..., in fill_details_from_wiki
FreeCAD.Console.PrintWarning(translate("AddonsInstaller", "Unable to clean macro code: ") + code + '\n')
TypeError: can only concatenate str (not "list") to str
```
which is fixed by these changes.

OS: Ubuntu 20.04.1 LTS
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.4.
Build type: Release
Python version: 3.8.2
Qt version: 5.12.5
Coin version: 4.0.0
OCC version: 7.3.0
Locale: English/United States (en_US)
Attach Issues:
mod - src/Mod/AddonManager/addonmanager_macro.py Diff File

master 2bf4448e

2020-10-20 12:50:23

yorik

Details Diff
TechDraw: Better tooltip for scale property
Attach Issues:
mod - src/Mod/TechDraw/App/DrawView.cpp Diff File

master 0d511d05

2020-10-20 12:43:33

yorik

Details Diff
Arch: Added SectionColor property to Arch Materials
Attach Issues:
mod - src/Mod/Arch/ArchMaterial.py Diff File
mod - src/Mod/Arch/ArchSectionPlane.py Diff File

master 1a2b75ab

2020-10-20 11:31:40

yorik

Details Diff
Draft: allow to scale imageplanes
Attach Issues:
mod - src/Mod/Draft/draftfunctions/scale.py Diff File
mod - src/Mod/Draft/draftguitools/gui_scale.py Diff File

master 87eae7c5

2020-10-20 11:13:54

yorik

Details Diff
Arch: Enabled ellipse-based walls - fixes 0003859 Affected Issues
0003859
mod - src/Mod/Arch/ArchWall.py Diff File
mod - src/Mod/Draft/draftgeoutils/offsets.py Diff File
1 2 3 4 ... 60 ... 120 ... 180 ... 240 ... 300 ... 360 ... 420 ... 480 ... 540 ... 569 570 571  Next  Last