FreeCADView Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000530 | FreeCAD | Bug | public | 2011-12-10 12:03 | 2011-12-10 17:41 |
| Reporter | sparr0 | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 0.11 | ||||
| Fixed in Version | 0.13 | ||||
| Summary | 0000530: Python Console allows editing of history | ||||
| Description | Being able to move the cursor into the console history and type or paste into it is confusing and problematic. The cursor should behave like a console, not like an editor. Bug 489 refers to this behavior but doesn't patch it. | ||||
| Tags | No tags attached. | ||||
| FreeCAD Information | |||||
|
|
The point is it is an editor. At the time we were using Qt3 it was possible to inherit from (I think it was) QTextEdit and reimplement a couple of methods so that it wasn't possible to edit upper text. With Qt4 most of those methods weren't virtual anymore and thus there was no easy way to achieve the same behaviour. The only way was to reimplement one single method but then you'd to copy/paste 99% of the code. |
|
|
I'm not sure what you mean by "it is an editor". What is the expected use case and desired outcome of me pasting code into the middle of a line in the history? |
|
|
The Python console class inherits from QPlainTextEdit which is a full-featured text editor. So, you have to re-implement certain methods to suppress all the features you don't want. Since this implementation wasn't touched for a long time I will re-check if the QT API has been changed to simplify this... |
|
|
The patch from 489 fixes almost all problems you mentioned. Using CTRL+V you cannot paste into the history but using the context-menu you can. I'll fix that. You can still put the cursor into the history but when entering text it does nothing. Here it might better to swtich to the input line. |
|
|
Fixed in rev 5258 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-12-10 12:03 | sparr0 | New Issue | |
| 2011-12-10 12:54 | wmayer | Note Added: 0001442 | |
| 2011-12-10 13:07 | sparr0 | Note Added: 0001443 | |
| 2011-12-10 14:48 | wmayer | Note Added: 0001450 | |
| 2011-12-10 15:21 | wmayer | Note Added: 0001451 | |
| 2011-12-10 15:21 | wmayer | Note Edited: 0001451 | |
| 2011-12-10 17:41 | wmayer | Note Added: 0001453 | |
| 2011-12-10 17:41 | wmayer | Status | new => closed |
| 2011-12-10 17:41 | wmayer | Resolution | open => fixed |
| 2011-12-10 17:41 | wmayer | Fixed in Version | => 0.13 |
